[quake3-commits] [ioquake/ioq3] 10abac: Fix duplicate bots displayed in Team Arena ingame ...

[Zack Middleton]

  Branch: refs/heads/master
  Home:   https://github.com/ioquake/ioq3
  Commit: 10abac8fa03e8a019dbe3ce8d1de544f1a25102a
      https://github.com/ioquake/ioq3/commit/10abac8fa03e8a019dbe3ce8d1de544f1a25102a
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2018-05-06 (Sun, 06 May 2018)

  Changed paths:
    M code/ui/ui_main.c

  Log Message:
  -----------
  Fix duplicate bots displayed in Team Arena ingame add bot menu

The key handler allowed going 2 beyond the end of the bot list and the
display function clamped to 0 causing the first bot to be shown 3 times.

Attempting to add the bot in gametypes < GT_TEAM would fallback to
Sarge in UI_GetBotNameByNumber() (who isn't the first bot) and gametypes
>= GT_TEAM would access characterList past known values (typically NULL
but if teaminfo.txt contained 63 characters it would access out of
bounds memory).



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.