[openbox] keyboard shortcuts for the root menu
danakj at orodu.net
Wed Jul 11 23:32:53 EDT 2007
On 7/8/07, Jonas J Linde <jonas at init.se> wrote:
> And Jonas J Linde spoke unto the world. And said:
> >And Jonas J Linde spoke unto the world. And said:
> >>And Dana Jansens spoke unto the world. And said:
> >>>On 6/29/07, Jonas J Linde <jonas at init.se> wrote:
> >>>If you want to go ahead and make it do all the stuff I've talked about
> >>>here (exclusively use _, without the option) against the 3.4-working
> >>>branch in SVN that would be cool, or I can do it when I get to it as
> >>OK, I'll start working on it.
> >Here's a new patch - this one against the 3.4-working branch. Skipping
> >the shortcut color bit made the patch a lot simpler although switching
> >from & to _ made it seven times larger.
> >I'll see if I can find a better way to use color instead of underline
> >and get back to you when I do.
> Hi again,
> So, here's the patch to allow menu.items.shortcut.color, (and optionally
> menu.items.active.shortcut.color, menu.items.disabled.shortcut.color and
> menu.items.active.disabled.shortcut.color) in the themerc file. I
> couldn't figure out a good way to remove an attribute from the Pango
> layout so it got a bit complicated with five layout attributes out of
> which only one is used at a time. I'm not convinced that this is the
> Correct Way to do it but at least it's a way.
> As I hinted previously, if menu.items.shortcut.color isn't set,
> underlining will be used instead so as not to break old themes.
> Would this be OK for inclusion in the next release?
Thanks for doing these. :)
I've merged your first patch into svn yesterday. The color stuff I
haven't yet. I'm sitting on my hands kinda, thinking about it. But
the way you've done it I don't think I will be able to find any
problem with it, so it will probably go in just like that. :)
More information about the openbox