[openbox] keyboard shortcuts for the root menu

Dana Jansens danakj at orodu.net
Thu Jul 19 12:50:53 EDT 2007

On 7/8/07, Jonas J Linde <jonas at init.se> wrote:
> And Jonas J Linde spoke unto the world. And said:
> >And Jonas J Linde spoke unto the world. And said:
> >>And Dana Jansens spoke unto the world. And said:
> >>>On 6/29/07, Jonas J Linde <jonas at init.se> wrote:
> >>>If you want to go ahead and make it do all the stuff I've talked about
> >>>here (exclusively use _, without the option) against the 3.4-working
> >>>branch in SVN that would be cool, or I can do it when I get to it as
> >>>well.
> >>
> >>OK, I'll start working on it.
> >
> >Here's a new patch - this one against the 3.4-working branch. Skipping
> >the shortcut color bit made the patch a lot simpler although switching
> >from & to _ made it seven times larger.
> >
> >I'll see if I can find a better way to use color instead of underline
> >and get back to you when I do.
> Hi again,
> So, here's the patch to allow menu.items.shortcut.color, (and optionally
> menu.items.active.shortcut.color, menu.items.disabled.shortcut.color and
> menu.items.active.disabled.shortcut.color) in the themerc file. I
> couldn't figure out a good way to remove an attribute from the Pango
> layout so it got a bit complicated with five layout attributes out of
> which only one is used at a time. I'm not convinced that this is the
> Correct Way to do it but at least it's a way.
> As I hinted previously, if menu.items.shortcut.color isn't set,
> underlining will be used instead so as not to break old themes.
> Would this be OK for inclusion in the next release?

So I've been thinking about it.  I have a branch in my repository
right now with this functionality in it.  I changed the theme element
names up, and did the code quite differently - the patch provided
broke all the render lib's (shotty) encapsulation.  But I'm really
hesitant to add this still, because for 99.9% of users, when they turn
on this option, nothing will happen, and they will consider it broken,
and file a bug report.  Maybe just using the opposite of the current
color would be better, like an xor operation does.  I will continue to
think about it, but it might not show up in the next release.


More information about the openbox mailing list