[openbox] keyboard shortcuts for the root menu

Jonas J Linde jonas at init.se
Sun Jul 8 18:37:27 EDT 2007


And Jonas J Linde spoke unto the world. And said:
>And Jonas J Linde spoke unto the world. And said:
>>And Dana Jansens spoke unto the world. And said:
>>>On 6/29/07, Jonas J Linde <jonas at init.se> wrote:
>>>If you want to go ahead and make it do all the stuff I've talked about
>>>here (exclusively use _, without the option) against the 3.4-working
>>>branch in SVN that would be cool, or I can do it when I get to it as
>>>well.
>>
>>OK, I'll start working on it.
>
>Here's a new patch - this one against the 3.4-working branch. Skipping
>the shortcut color bit made the patch a lot simpler although switching
>from & to _ made it seven times larger.
>
>I'll see if I can find a better way to use color instead of underline
>and get back to you when I do.

Hi again,

So, here's the patch to allow menu.items.shortcut.color, (and optionally
menu.items.active.shortcut.color, menu.items.disabled.shortcut.color and
menu.items.active.disabled.shortcut.color) in the themerc file. I
couldn't figure out a good way to remove an attribute from the Pango
layout so it got a bit complicated with five layout attributes out of
which only one is used at a time. I'm not convinced that this is the
Correct Way to do it but at least it's a way.

As I hinted previously, if menu.items.shortcut.color isn't set,
underlining will be used instead so as not to break old themes.

Would this be OK for inclusion in the next release?

Cheers,
-- 
Jonas J Linde <jonas at init.se>  http://www.init.se/~jonas/ +46-707-492496
<---------------------------------------------------------------------->
GE/IT$ d-() s++: a C++(++++)$ UBVL++(++++)$ P+++ L+++$ E++ W++(-) N+ o--
K+ !w(+) O M@ V PS+ PE++(-) Y+ PGP+(++) t 5 X R-@ tv- b+>++ DI D++ G+(-)
e+++ h+(----) r@ y++++ UF+
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openbox-3.4-working-shortcut_color.patch
Type: text/x-diff
Size: 9943 bytes
Desc: not available
URL: <http://icculus.org/pipermail/openbox/attachments/20070709/88d3d79d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://icculus.org/pipermail/openbox/attachments/20070709/88d3d79d/attachment.pgp>


More information about the openbox mailing list