GTK+ Browse for install path patch

Scott Brooks scott at hermitworksentertainment.com
Fri Sep 14 02:35:53 EDT 2007


So I decided to start on improving the GTK+ interface as much as I can.

Attached is a patch to add a Browse button to the choose the destination
page.

Some questions/comments though
1) I noticed that things are at an 80 char line length.  I went over it by a
few chars, but is that a hard and fast rule you would like me to abide by?
2) I adjusted create_button to accept the callback we want for the signal
3) Is the rest of the patch sane?
This is my first GTK+ codebase to hack on, so I would rather start learning
the correct habits.
4) How do you prefer contributions?  E-mailed diff's?

Once I get used to GTK+, I'll start trying to pretty it up a bit more.

--
Scott Brooks
Programmer
HermitWorks Entertainment
http://www.hermitworksentertainment.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://icculus.org/pipermail/mojosetup/attachments/20070914/70758733/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add_browse_button.diff
Type: text/x-patch
Size: 3674 bytes
Desc: not available
URL: <http://icculus.org/pipermail/mojosetup/attachments/20070914/70758733/attachment.bin>


More information about the mojosetup mailing list