Small memory-leak in MOD decoder

Max Horn max at
Mon Oct 1 09:13:50 EDT 2001

At 13:57 Uhr +0200 01.10.2001, Torbjörn Andersson wrote:
>Max Horn wrote:
>>  If somebody could tell me what we are talking about here, sure, I will
>>  look at it :) I read the mails about the MP3-ness chaeck, but how is
>>  this related to libtool ??!? what libtool patch?!?
>You're right, they're not related. I was just lumping them together 
>as two items that have been discussed but not yet committed to CVS. 
>>  You mean CVS rev 1.1 vs 1.2 of acinclude.m4, and 1.2 is not working -
>>  well, it contains libtool.m4. But one could argue whether that is a
>>  good idea, since we require libtool anyway... I think it is better to
>>  add a comment regarding this to the readme, and get rid of libtool.m4
>>  in acinclude - this way both users of 1.3.x and 1.4.x can be happy.
>Or the bootstrap script could be made to construct the appropriate 
>acinclude.m4 depending on what "libtool --version" says, I guess. 
>Might be overkill though.

It would be - because that is exactly what "aclocal" does :)

aclocal scans the file for all required macros; then it 
looks through acinclude.m4 to satisfy these requirments; finally, it 
searches $prefix/share/aclocal/ for .m4 files that define those 
macros. The resulting set of macros is put into the file aclocal.m4, 
which then is used by the other auto-tools to resolve the macros.

The idea behind having an acinclude.m4 at all is that if somebody has 
OGG not installed at all, he is also missing the vorbis.m4; but then 
the autotools could not handle the vorbis macros. Solution: put those 
into acinclude.m4. Problem: if a new version of the macros is 
substantially changed, you get problems.

This happend for libtool :/

But since libtool is required (whereas ogg is not), we can safely 
leave out our copy of libtool.m4

Max Horn
Software Developer

email: <mailto:max at>
phone: (+49) 6151-494890

More information about the sdlsound mailing list