[quake3] 'Remove Useless setuid code' ???

[vincent at cojot.name]

On Sat, 3 Sep 2005, Ian Kumlien wrote:

> On Sat, 2005-09-03 at 15:41 +0200, vincent at cojot.name wrote:
>> Just saw a bunch of 'Remove Useless setuid code' in svn.
>
> It seems like the setuid is infact useless and related to that root
> usually owns devices like that... I also seem to remember that id
> discuraged ppl from running it setuid.. (i'm tired though so it might be
> context leakage).
>
> Anyways, if we merged that, then why not <see attachment/>

In q2 we had this (amazing how some code looks identical...):

[...snip...]
         if ( ( glw_state.OpenGLLib = dlopen( dllname, RTLD_LAZY ) ) == 0 )
         {
                 char    fn[MAX_OSPATH];
                 char    *path;

                 // try basedir next
                 path = ri.Cvar_Get ("basedir", ".", CVAR_NOSET)->string;

                 snprintf (fn, MAX_OSPATH, "%s/%s", path, dllname );

                 if ( ( glw_state.OpenGLLib = dlopen( fn, RTLD_LAZY ) ) == 0 ) {
                         ri.Con_Printf( PRINT_ALL, "%s\n", dlerror() );
                         return false;
                 }
                 Com_Printf ("Using %s for OpenGL...", fn);
         } else {
                 Com_Printf ("Using %s for OpenGL...", dllname);
         }
[...snip...]


-- 
,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,
Vincent S. Cojot, Computer Engineering. STEP project. _.,-*~'`^`'~*-,._.,-*~
Ecole Polytechnique de Montreal, Comite Micro-Informatique. _.,-*~'`^`'~*-,.
Linux Xview/OpenLook resources page _.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'
http://step.polymtl.ca/~coyote  _.,-*~'`^`'~*-,._ coyote at NOSPAM4cojot.name

They cannot scare me with their empty spaces
Between stars - on stars where no human race is
I have it in me so much nearer home
To scare myself with my own desert places.       - Robert Frost