[quake3-bugzilla] [Bug 4358] Vertex Buffer Object (VBO) code available
bugzilla-daemon at icculus.org
bugzilla-daemon at icculus.org
Tue May 10 15:59:11 EDT 2011
https://bugzilla.icculus.org/show_bug.cgi?id=4358
--- Comment #31 from Matt Turner <mattst88 at gmail.com> 2011-05-10 15:59:08 EDT ---
Lots of trailing whitespace in the patch. Also, a lot of Window's newlines.
A few other problems I see:
- You can't #define preprocessor identifiers that start with GL_, since they're
reserved. (See GL_{MODULATE,ADD,REPLACE}).
- Trying to take the dot of a vec3 and vec4. texture2D() returns a vec4. See
http://www.opengl.org/wiki/GLSL_:_common_mistakes
float dist = dot(dist3, vec3(1.0 / (256.0 * 256.0), 1.0 / 256.0, 1.0)) *
u_LightRadius;
Also, when I disabled r_arb_*, maps fail to load with 'ERROR: Hunk_Alloc failed
on 3179808' or similar.
--
Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the quake3-bugzilla
mailing list