[quake3-bugzilla] [Bug 4698] [patch] allow changing claimed protocol version at command line

bugzilla-daemon at icculus.org bugzilla-daemon at icculus.org
Thu Feb 10 14:53:00 EST 2011


Thilo Schulz <arny at ats.s.bawue.de> changed:

           What    |Removed                     |Added
                 CC|                            |arny at ats.s.bawue.de

--- Comment #4 from Thilo Schulz <arny at ats.s.bawue.de> 2011-02-10 14:52:58 EST ---
I have these comments to these patches:

FS_FOpenFileRead: allow loading any demo, not just the current protocol
Load demos using the protocol version from the command line, if overridden

How are we supposed to take into account the global variable demo_protocols,
which is defined in common.c? There is a reason why it checks against a list of
supported protocols. I guess the best thing you can do is check for these
protocol versions in common.c + additionally the new protocol version as
defined in the cvar, but reject all other protocols. Is this the case with your
current patch?

Second issue I have with your second patch is that you named the cvar
"sv_protocol". There's no reason for this, it should be called "com_protocol",
because the client AND server both need the protocol version.

I will accept your patches once these issues are resolved. Thank you for your
contributions, they are appreciated.

Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the quake3-bugzilla mailing list