[quake3-bugzilla] [Bug 4894] New: EasyClientName unnecessarily strcpys a buffer into itself

bugzilla-daemon at icculus.org bugzilla-daemon at icculus.org
Sat Feb 5 13:45:45 EST 2011


           Summary: EasyClientName unnecessarily strcpys a buffer into
           Product: ioquake3
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Misc
        AssignedTo: zakk at icculus.org
        ReportedBy: smcv-ioquake3 at pseudorandom.co.uk
         QAContact: quake3-bugzilla at icculus.org

Created attachment 2579
  --> https://bugzilla.icculus.org/attachment.cgi?id=2579
proposed patch

I tried running an OA server under Valgrind. Among other things, it complains
that EasyClientName calls strcpy with overlapping buffers, which isn't valid;
it turns out to be copying a string to the same string, which is useless at
best.  See attached patch.

Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the quake3-bugzilla mailing list