[quake3-bugzilla] [Bug 4699] [patch] FS_CheckPak0 requires baseq3/pak0.pk3 even if com_standalone is 1

[bugzilla-daemon at icculus.org]

http://bugzilla.icculus.org/show_bug.cgi?id=4699

Tim Angus <tim at ngus.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tim at ngus.net

--- Comment #4 from Tim Angus <tim at ngus.net> 2010-08-26 06:14:22 EDT ---
(In reply to comment #3)
> What I aimed to change with this patch is that the check for whether we need
> the baseq3 assets is too strict: if I set com_standalone to 1, fs_basegame to
> baseoa, and fs_basepath to a location that contains baseoa but not baseq3, the
> engine still checks "do I have baseq3/pak0.pk3?", discovers that it does not,
> and refuses to run.

I think perhaps you're misinterpreting the purpose of fs_basegame. It came
about in response to the Team Arena expansion being released, so that people
could make Team Arena mods. i.e. setting fs_basegame doesn't and shouldn't
break the dependence on baseq3, what's it's saying is fs_game inherits
fs_basegame inherits baseq3. I hope that makes sense.

--- Comment #5 from Simon McVittie <smcv-ioquake3 at pseudorandom.co.uk> 2010-08-26 06:59:34 EDT ---
(In reply to comment #4)
> I think perhaps you're misinterpreting the purpose of fs_basegame. It came
> about in response to the Team Arena expansion being released, so that people
> could make Team Arena mods. i.e. setting fs_basegame doesn't and shouldn't
> break the dependence on baseq3, what's it's saying is fs_game inherits
> fs_basegame inherits baseq3. I hope that makes sense.

I see. I'd been using fs_basegame can also be used to get a 2-level hierarchy
(e.g. OpenArena -> Excessive Plus) with an unmodified engine binary, if the
fs_basegame happens to be one like OpenArena or Urban Terror that doesn't
reference the baseq3 assets anyway; as a side-effect, the BASEGAME (i.e.
baseq3) directory will still be on the search path, but as a result of the
check Thilo mentioned, we won't actually allow ourselves to use any of the
baseq3 assets without disabling com_standalone.

Would you prefer a patch that added a fs_rootgame or fs_basebasegame or
something, which is a CVAR_INIT version of the hard-coded BASEGAME? The default
for fs_basegame could then change to be the value of fs_rootgame (I'd have to
be careful to initialize fs_rootgame first :-), but FS_CheckPak0 would still be
interested in BASEGAME.

Relatedly, it might make more sense to check for a hard-coded "baseq3" in
FS_CheckPak0.

One complicating factor is that OpenArena also has an unfinished pseudo-mod
called "missionpack" (which has the GPL'd game logic from Team Arena, but
otherwise has nothing to do with it), so when running a non-baseq3 "root game",
"missionpack" shouldn't be rejected.

-- 
Configure bugmail: http://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.