[quake2] Re: [evil patch] hwgamma hack for voodoo1/voodoo2

O.Sezer sezeroz at gmail.com
Mon Dec 12 12:35:42 EST 2005

Brendan Burns wrote:
> I agree with Vincent, that Voodoo cards are rarely used.  But its worth
> supporting them if it doesn't break other stuff..  Here's my suggestion:
> * Migrate all 3dfx related code out into its own file.
> (this means removing Check3dfxGamma, Update3dfxGamma from gl_glx.c and
> moving them to the newly added fx_gamma.c)
> * Get rid of GL_GammaInit, add a GL_3dfxInit to fx_gamma.c
> * put #ifdef V_3DFX ... #endif around all extern functions related to
> 3dfx in gl_glx and 
> * put an #ifdef'd call to GL_3dfxInit in R_init, likewise for the Update
> and Shutdown functions.
> Can you revise and send a new patch?
> Thanks!
> --brendan

I revised the patch, which is attached:
The feature is bound to a Makefile option, defaulting to NO.
Even if set to yes, it is only enabled on i386-Linux, not on
anything else. GL_GammaInit() stuff removed, fxgamma decision
is made while we are in  GLimp_SetMode(). 3dfxGamma is applied
from within UpdateHardwareGamma().
I think it's much less intrusive now. If it is to be applied,
remember that it requires the RTLD_GLOBAL patch pre-applied.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: q2-3dfxgamma-3.patch
URL: <http://icculus.org/pipermail/quake2/attachments/20051212/94791435/attachment.diff>

More information about the quake2 mailing list