[physfs] [latest tip, 3b7e318f978c] Reading at EOF causes stack overflow in doBufferedRead

[Ryan C. Gordon]

On 9/24/17 1:22 PM, Paril wrote:
> The buffered reading function will fail at EOF; it will continuously add 
> 0 bytes to the read length and never stop despite receiving 0 bytes from 
> io->read. Currently we are able to reproduce by reading a file 1 byte at 
> a time, which will fail once you reach the last byte. I think the POSIX 
> route might even assert since the len read will be < the len in (1 byte 
> in, 0 bytes read), but I only tested it on Windows so far.

This is fixed now by https://hg.icculus.org/icculus/physfs/rev/1cfcdfa86341

> Using libsndfile with a wrapper to PHYSFS, a crash seems to occur as the 
> system tries to do some reading from the beginning.

This is fixed now, too, by 
https://hg.icculus.org/icculus/physfs/rev/5c5f95f1d5ff

Thanks for digging into this for me! Let me know if you hit anything else!

--ryan.