[openbox] PATCH - sloppy focus

Mikael Magnusson mangosoft at comhem.se
Sun Nov 16 14:51:41 EST 2003

On Sun, 16 Nov 2003 corey at streamreel.net wrote:

> On Sun, Nov 16, 2003 at 11:51:40AM +0100, Mikael Magnusson wrote:
> >
> > is this what you meant?
> > 
> > Index: openbox/config.c
> <snip>
> > +gboolean config_focus_first;
> <snippity-snip>  
>   That looks to me like just a different approach to acheiving the same
>   effect that my own patch provided - yours introduces a new
>   configuration option.
>   If we're going to do that, might as well go the extra step and include
>   the ability to specify a separate 'config_focus_delay' and
>   'config_raise_delay'. A 'config_focus_first' option ("focusFirst")
>   seems strange to me - I haven't seen it presented that way in other
>   wm's... in fact, it's my understanding/experience that "focusFirst"
>   should be the implicit and expected behavior.

You can't go around changing the default behaviour after a stable release 
you know. I realize my choice of configuration name is not very good, but 
it had to have some name. Introducing one more timeout in the code is not 
entirely painfree, I did a patch for this a while back but we concluded 
that nobody would want it.

>   But I'm mostly interested in simply getting the focus model in ob3 to
>   work in, what I believe is, the "correct" manner. It's possible that
>   this is merely my own personal preference on the matter, but I'm
>   pretty sure that actualy what I'm suggesting is the "normal" behavior.

Do you have a problem with the default not being what you want? The way 
this patch works is this: You set a delay with focusDelay, the name 
probably should be changed if this implementation is chosen. You then say 
if you want autoRaise on, and if you say that you want it on, you also say 
if you want the delay to be for focusing and raising or just for raising. 
It is thus a roundabout way of choosing if you want the delay to apply to
a) focusing
b) raising
c) focusing+raising

>   Does anyone else here use focus follows mouse? Does anyone else here
>   agree or disagree with me? I'm new here, and certainly don't want to
>   come across as though I know best.

I obviously disagree

> Cheers,
> Corey

Wanting-to-have-clever-ending-remarks-like-tim-riley-ey yours,
Mikael Magnusson

More information about the openbox mailing list