[aquaria] SDL2 patches...

False.Genesis false.genesis at googlemail.com
Fri Jul 19 08:48:35 EDT 2013

> Long overdue, here are the SDL2 patches I promised.

Finally, thanks for this!

I had to adjust the patch a bit to apply against my repo, but works well 

There's however a reliable segfault during SDL shutdown, caused by 
improper cleanup in Joystick::shutdown().
Another problem is that even though the timeout for the rumble effect is 
set, it doesn't stop. (Using XBox360 controller on WinXP)
I worked around it by using a timer that was already there.

See the following commit for a fix: 
(ignore the double->float change)

Did only test on win32 so far, if I notice problems on linux/osx i'll shout.

@ Ryan:
Is there a function that needs to be called in every cycle to 
update/expire haptic effects, or is that supposed to be done 
automatically? Because a quick grep over haptic/windows/SDL_syshaptic.c 
shows only one appearance of IDirectInputEffect_Stop(), and this is in 
(I checked out SDL via hg today to make sure this isn't an already fixed 

Btw, is there any chance that the changes done to the opensource code 
will be added to the steam/HiB versions at some point? I don't care 
about licensing so if this is going to happen just take my patches and 
throw them at your code.
I'm just a bit disappointed that everyone still ships code from 5 years ago.

More information about the aquaria mailing list