[quake3-commits] [ioquake/ioq3] 738465: Revert my recent cvar latch changes

[Zack Middleton]

  Branch: refs/heads/master
  Home:   https://github.com/ioquake/ioq3
  Commit: 738465d677bddac1385da7d6099b58ca0c4a797f
      https://github.com/ioquake/ioq3/commit/738465d677bddac1385da7d6099b58ca0c4a797f
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2018-01-21 (Sun, 21 Jan 2018)

  Changed paths:
    M code/client/cl_main.c
    M code/qcommon/common.c
    M code/qcommon/cvar.c
    M code/qcommon/files.c

  Log Message:
  -----------
  Revert my recent cvar latch changes

My cvar latch system changes prevent the Game VM from changing
g_gametype when the value is out of range due to it being registed in
the engine. It's been pointed out as fragile method of security, which
was still exploitable, by Noah Metzger (Chomenor). It doesn't seem like
this is working out to be a good solution.

The issue of fs_game '..' on server being relicated on client via
systeminfo exploit is still fixed as it's not affected by latch.
There are a few cases from current values of fs_game are used which
ideally should use fs_gamedir char array which has been validated.

Revert "Don't let VMs change engine latch cvars immediately"
Partially revert "Fix fs_game '..' reading outside of home and base path"
Revert "Fix VMs forcing engine latch cvar to update to latched value"