[quake3-commits] [ioquake/ioq3] 4ea0ee: Fix nullptr dereference in front of nullptr check ...

Dominic Fandrey kamikaze at bsdforen.de
Sun Apr 8 23:06:13 EDT 2018


  Branch: refs/heads/master
  Home:   https://github.com/ioquake/ioq3
  Commit: 4ea0eebfe5eb13945ea0689349185bb0b68e3c1b
      https://github.com/ioquake/ioq3/commit/4ea0eebfe5eb13945ea0689349185bb0b68e3c1b
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M code/qcommon/files.c

  Log Message:
  -----------
  Fix nullptr dereference in front of nullptr check in FS_CheckPak0

Found using LLVM sanitizer. Reported by Dominic "lonkamikaze" Fandrey
and David "devnexen" CARLIER.


  Commit: a494edeb94fd9ac36087cd9f0f49d184879ec0af
      https://github.com/ioquake/ioq3/commit/a494edeb94fd9ac36087cd9f0f49d184879ec0af
  Author: Dominic Fandrey <kamikaze at bsdforen.de>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M code/client/snd_mem.c

  Log Message:
  -----------
  Fix undefined behaviour due to shifting signed in snd_mem.c


  Commit: ae9edd14916a9923d0a418b8eec6b246858758c3
      https://github.com/ioquake/ioq3/commit/ae9edd14916a9923d0a418b8eec6b246858758c3
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M code/renderercommon/tr_font.c

  Log Message:
  -----------
  Fix shifting bits out of byte in tr_font.c

Found using LLVM sanitizer. Reported by Dominic "lonkamikaze" Fandrey.


  Commit: 62cec249d7140c3a2378501cf22b8c26e4497c76
      https://github.com/ioquake/ioq3/commit/62cec249d7140c3a2378501cf22b8c26e4497c76
  Author: Dominic Fandrey <kamikaze at bsdforen.de>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M code/client/cl_cin.c

  Log Message:
  -----------
  Fix shift into sign in cl_cin.c


  Commit: 3a702ded6562741617ba8a35e90ab55506740f91
      https://github.com/ioquake/ioq3/commit/3a702ded6562741617ba8a35e90ab55506740f91
  Author: Dominic Fandrey <kamikaze at bsdforen.de>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M code/qcommon/msg.c

  Log Message:
  -----------
  Fix signed bit operations in MSG_ReadBits


  Commit: bf4c7a0341ae000188c4e226f55813f7e80a1dfa
      https://github.com/ioquake/ioq3/commit/bf4c7a0341ae000188c4e226f55813f7e80a1dfa
  Author: Dominic Fandrey <kamikaze at bsdforen.de>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M code/qcommon/cm_polylib.c

  Log Message:
  -----------
  Add missing address operator in cm_polylib.c

Also avoid nullptr dereference.


  Commit: a740ba47dd2410396cc2405e7a224a82bbf44684
      https://github.com/ioquake/ioq3/commit/a740ba47dd2410396cc2405e7a224a82bbf44684
  Author: Dominic Fandrey <kamikaze at bsdforen.de>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M code/renderergl1/tr_marks.c

  Log Message:
  -----------
  OpenGL1: Decay float[8] to float * in tr_marks.c


  Commit: b8ee77cecc749139c04d7d3684ff5d1f0972a53b
      https://github.com/ioquake/ioq3/commit/b8ee77cecc749139c04d7d3684ff5d1f0972a53b
  Author: Dominic Fandrey <kamikaze at bsdforen.de>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M code/client/snd_openal.c

  Log Message:
  -----------
  Avoid srcList[-1] in snd_openal.c


Compare: https://github.com/ioquake/ioq3/compare/9f294ce5207f...b8ee77cecc74


More information about the quake3-commits mailing list