[quake3-commits] [ioquake/ioq3] 729766: Don't start a vote after vote passed for map chang...

[Zack Middleton]

  Branch: refs/heads/master
  Home:   https://github.com/ioquake/ioq3
  Commit: 729766150f376b3c18dd4a0bc05e17d93cc95865
      https://github.com/ioquake/ioq3/commit/729766150f376b3c18dd4a0bc05e17d93cc95865
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M code/game/g_cmds.c

  Log Message:
  -----------
  Don't start a vote after vote passed for map change

Processing a callvote command after a vote passed to change maps but
has not been executed yet will result in 1) map change immediately
happening 2) after new map loads players have vote HUD messages but
Game VM doesn't have a vote in progress. The phantom vote status will
only be removed if players start a new vote or run vid_restart.

The underlying issue is that a second callvote sets vote config
strings but a map change is executed before they are sent to clients.
Resulting in clients getting "cs" reliable commands with the config
string changes _after_ the map change. Out of sync config strings.

Even if the underlying issue was fixed, the second vote would be lost.
So it's best to not force a map change to happen immediately anyway.

Reported by Tobias Kuehnhammer.