[quake3-bugzilla] [Bug 5450] New: SV_SetUserinfo() incomplete?

[bugzilla-daemon at icculus.org]

https://bugzilla.icculus.org/show_bug.cgi?id=5450

           Summary: SV_SetUserinfo() incomplete?
           Product: ioquake3
           Version: SVN HEAD
          Platform: PC
        OS/Version: Windows Vista
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: Misc
        AssignedTo: zakk at icculus.org
        ReportedBy: lrq3000 at gmail.com
         QAContact: quake3-bugzilla at icculus.org


In sv_init.c, SV_SetUserinfo() does not follow the same procedure as
SV_UpdateUserinfo_f() in sv_client.c, basic summary:

SV_SetUserinfo():
- Set the userinfo string for the specified client
- Update the name field

SV_UpdateUserinfo_f():
- Set the userinfo string for the client
- Update ALL client_t fields (by calling SV_UserinfoChanged() )
- Propagate the change to the gamecode via a VM_CALL
GAME_CLIENT_USERINFO_CHANGED

As you can see, while the first function only updates one client_t field, the
latter one updates all the fields and propagate the changes to the gamecode. Is
there a reason for that?

Also, SV_UpdateUserinfo_f() is static, while SV_SetUserinfo() is not, so an
external module can only access the incomplete SV_SetUserinfo()...

-- 
Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.