[quake3-bugzilla] [Bug 4974] New: overzealous cvar cheat protection

[bugzilla-daemon at icculus.org]

https://bugzilla.icculus.org/show_bug.cgi?id=4974

           Summary: overzealous cvar cheat protection
           Product: ioquake3
           Version: SVN HEAD
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P3
         Component: Misc
        AssignedTo: zakk at icculus.org
        ReportedBy: andi.christ at gmx.net
         QAContact: quake3-bugzilla at icculus.org


Created attachment 2685
  --> https://bugzilla.icculus.org/attachment.cgi?id=2685
this patch removes the mentioned cvar resetting

When the (non-dedicated) server is started, all cheat protected cvars loaded
from the config and command line get reset to their default values, if default
values exist at that point, game and cgame cvars are not affected. For example,
starting the game with arguments "+set bot_developer 1 +devmap q3dm1" will
result in bot_developer being 0. Throwing "+set sv_cheats 1" in there doesn't
change that. The code responsable for resetting the cvars runs after the UI VM
is initialized and does make little sense:

- the client cleans up its cvars anytime it connects to a cheats-off server, so
why do it one extra time, at a point where it's not connected to any server,
and might join a cheats-on server next, like in the case above?

- the code checks clc.demoplaying and cl_connectedToCheatServer before
resetting the cvars. Both variables cannot have been set at this stage, so it's
pointless to check them.

I suggest removing the cvar resetting code.

-- 
Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.