[quake3-bugzilla] [Bug 4919] New: Extra variable in missionpack ui's bind_t structure

bugzilla-daemon at icculus.org bugzilla-daemon at icculus.org
Fri Mar 4 02:31:44 EST 2011


           Summary: Extra variable in missionpack ui's bind_t structure
           Product: ioquake3
           Version: SVN HEAD
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: P3
         Component: Misc
        AssignedTo: zakk at icculus.org
        ReportedBy: ZTurtleMan at gmail.com
         QAContact: quake3-bugzilla at icculus.org

Created attachment 2626
  --> https://bugzilla.icculus.org/attachment.cgi?id=2626
Remove unused 'int id;' from missionpack ui bind_t.

Missionpack ui has 'int id;' in its bind_t, but 'id' is unused and there is no
'id' data in g_bindings. 'id' field is skipped in g_bindings definition, so
data fields after 'id' are labeled wrong. After looking at code and testing, it
appears nothing should change if 'id' is removed.

If 'Controls_SetConfig(qtrue);' was placed after 'Controls_SetDefaults();' in
ui_main.c it would now set default binds for controls, instead of doing
nothing. Default binds in g_bindings would need changes before that should be
added ioq3.

Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the quake3-bugzilla mailing list