[quake3-bugzilla] [Bug 5099] Add support for dpmaster protocol

[bugzilla-daemon at icculus.org]

https://bugzilla.icculus.org/show_bug.cgi?id=5099

--- Comment #33 from Mathieu Olivier <molivier at icculus.org> 2011-07-30 15:04:31 EDT ---
(In reply to comment #32)
> Here's a proof-of-concept patch series for dpmaster, with a regression test (I
> was delighted to see that dpmaster has regression tests, they're definitely the
> way forward!). When it receives a heartbeat that implies a particular game
> name, it considers it to be a first guess; when it receives an infoResponse, it
> re-evaluates the game based on the protocol.
> 
> It also adds OpenArena to the table of known games, calling it "openarena", so
> that the getserversExt issued by OA 0.8.5 will retroactively start working :-)
> 
> Adding backwards-compat for a mod that uses the Q3 heartbeat and protocol 666,
> and wants to use com_gamename=HypotheticalMod when upgrading to ioquake3 r2105,
> would work like this:
> 
>     ./src/dpmaster -g HypotheticalMod lookslike=Quake3Arena protocols=666
> 
> hg repository (I hope I got this right, I haven't used hg before):
> 
>     https://bitbucket.org/smcv/dpmaster/

What? Wait, I never said I intended to add anything like that to dpmaster. If
tomorrow someone modifies the original Q3A source and pick "71" as its new
network protocol, I don't see any reason why the servers should be registered
as "openarena". On a more general note, the game properties have been added to
allow an easier integration of closed-source games, not to fix bugged
open-source games.

The bottom line is: I'm not modifying dpmaster in any way to fix on the master
side something that is broken on the game side. I've already refused to do that
for other games that weren't using the protocol correctly. OA is no exception,
sorry.

I can definitely integrate your modifications to the test suite, but not your
"lookslike" property or OA hardcoded properties.

-- 
Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.