[quake3-bugzilla] [Bug 5094] Code cleanup

[bugzilla-daemon at icculus.org]

https://bugzilla.icculus.org/show_bug.cgi?id=5094

Thilo Schulz <arny at ats.s.bawue.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arny at ats.s.bawue.de

--- Comment #5 from Thilo Schulz <arny at ats.s.bawue.de> 2011-07-26 20:54:14 EDT ---
I have a few questions to your patch, Zack:

You're removing
UI_DemosMenu_Key
Are you sure there is no chance of this function ever being called?

-       s_demos.menu.key = UI_DemosMenu_Key;

What makes you so sure that this callback is not triggered from some other
function in another C-file?


Why are you removing:
+       //sfxHandle_t   sfx_chghit;
+       //sfxHandle_t   sfx_chghitflesh;
+       //sfxHandle_t   sfx_chghitmetal;

when it's being used here:
        case WP_CHAINGUN:
                mod = cgs.media.bulletFlashModel;
-               if( soundType == IMPACTSOUND_FLESH ) {
+               /*if( soundType == IMPACTSOUND_FLESH ) {
                        sfx = cgs.media.sfx_chghitflesh;

and why do you disable the use of sfx_chghitflesh?


Aside from that I guess most is fine. Also the variables devhc mentions can be
safely removed.

-- 
Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.