[quake3-bugzilla] [Bug 5094] Code cleanup

[bugzilla-daemon at icculus.org]

https://bugzilla.icculus.org/show_bug.cgi?id=5094

/dev/humancontroller <devhc97 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |devhc97 at gmail.com

--- Comment #2 from /dev/humancontroller <devhc97 at gmail.com> 2011-07-21 01:59:55 EDT ---
Thilo: you have been recently working on the VM and the networking code. take a
particular look at these hunks (taken from the above patch), and assert that
nothing logical has been overlooked around them:

Index: code/qcommon/vm_x86.c
===================================================================
--- code/qcommon/vm_x86.c    (revision 2095)
+++ code/qcommon/vm_x86.c    (working copy)
@@ -1716,7 +1716,6 @@
 {
     byte    stack[OPSTACK_SIZE + 15];
     void    *entryPoint;
-    int        programCounter;
     int        programStack, stackOnEntry;
     byte    *image;
     int    *opStack;
@@ -1733,8 +1732,6 @@
     // set up the stack frame 
     image = vm->dataBase;

-    programCounter = 0;
-
     programStack -= 48;

     *(int *)&image[ programStack + 44] = args[9];
Index: code/qcommon/net_chan.c
===================================================================
--- code/qcommon/net_chan.c    (revision 2095)
+++ code/qcommon/net_chan.c    (working copy)
@@ -243,7 +243,6 @@
 */
 qboolean Netchan_Process( netchan_t *chan, msg_t *msg ) {
     int            sequence;
-    int            qport;
     int            fragmentStart, fragmentLength;
     qboolean    fragmented;

@@ -264,7 +263,7 @@

     // read the qport if we are a server
     if ( chan->sock == NS_SERVER ) {
-        qport = MSG_ReadShort( msg );
+        MSG_ReadShort( msg );
     }

 #ifdef LEGACY_PROTOCOL

-- 
Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.