[quake3-bugzilla] [Bug 5080] [patch] code/sys/sys_unix.c:Sys_Dialog doesn't check exit codes properly

[bugzilla-daemon at icculus.org]

https://bugzilla.icculus.org/show_bug.cgi?id=5080

--- Comment #8 from Simon McVittie <smcv-ioquake3 at pseudorandom.co.uk> 2011-07-18 06:59:11 EDT ---
(In reply to comment #6)
> Hopefully it'll be enough to tack on a "&> /dev/null" to the commands.

&> is a bash extension and won't work in (at least) dash; please use
">/dev/null 2>/dev/null", which is portable (and specified by POSIX [1]).

The Autoconf documentation has some good information on what is and isn't
portable in shell scripts, even if you're not actually using Autoconf.

> The
> assumption is that we're using some breed of sh, so I guess that's fair.

system() is specified by POSIX [2] in terms of "sh -c", where sh is a POSIX
(Bourne-derived) shell. Typically that means /bin/sh, which is a symlink to
bash, dash, ksh or something.

[1]
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_07_02
[2] http://pubs.opengroup.org/onlinepubs/9699919799/functions/system.html

-- 
Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.