[quake3-bugzilla] [Bug 5080] [patch] code/sys/sys_unix.c:Sys_Dialog doesn't check exit codes properly

[bugzilla-daemon at icculus.org]

https://bugzilla.icculus.org/show_bug.cgi?id=5080

--- Comment #6 from Tim Angus <tim at ngus.net> 2011-07-18 06:20:41 EDT ---
(In reply to comment #4)
> Tim: That's fine if you want to try to execute commands that don't exist.

Yes, that's how it's supposed to work, but I confess I hadn't considered...

> Since you want to run through all of the commands in ioquake3, you will also
> want to redirect stdout and stderr of the processes so it doesn't clutter the
> screen with "sh: <command> not found" messages.

Hopefully it'll be enough to tack on a "&> /dev/null" to the commands. The
assumption is that we're using some breed of sh, so I guess that's fair.

> However, < 64 is not safe.  When I run xmessage, I get 101 when I click ok.

OK, that's a problem. I've fixed that.

> To summarize, you can assume 127 = command not found and then you need to force
> all three commands to return certain return codes or go through them all and
> find out what they return.

OK.

-- 
Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.