[quake3-bugzilla] [Bug 4962] Protocol version 69 + legacy support

[bugzilla-daemon at icculus.org]

https://bugzilla.icculus.org/show_bug.cgi?id=4962

--- Comment #30 from Simon McVittie <smcv-ioquake3 at pseudorandom.co.uk> 2011-07-12 03:38:29 EDT ---
This is looking good! Some minor comments:

+  com_protocol                      - when encountering a server/client that
+                                      only supports the version configured in
+                                      this cvar

"... that does not support the version ...", surely?

+  If the value for "com_protocol" and "com_legacyprotocol" is identical, then
+  the legacy protocol is always used. If protocol is set to 0, then support
for
+  the legacy protocol is disabled.

"If com_legacyprotocol is set to 0" presumably?

+  Mods that use a standalone engine obviously do not require dual protocol
+  support

I think this is misleading: "do not require dual-protocol support unless they
intend to maintain backwards compatibility with older versions" would be
better?

I'd personally be inclined to make LEGACY_PROTOCOL always be defined, to avoid
the #ifdefs (standalone mods that don't want it can just set com_legacyprotocol
to 0); how much size does it actually add to the engine?

+             NET_OutOfBandPrint(NS_SERVER, from, "print\nGame mismatch: This
is a %s server\n",

To avoid bad grammar when a mod starts with a vowel ("this is a OpenArena-1
server"), perhaps this could be "Game mismatch: this server runs %s"?

+#define    PROTOCOL_VERSION    69
+#define PROTOCOL_LEGACY_VERSION    68
 // 1.31 - 67

Should these maybe go in q_shared.h, if standalone mods are going to be
changing them?

Maybe extend the comment:

 // 1.31 - 67
 // 1.32c - 68
 // PROTOCOL_LEGACY_VERSION will be 68 forever, except in standalone mods
 // ioquake3 1.37 - 69

Maybe it'd be good to have some convention like "protocol = legacy protocol +
100" (then +200 if you break compat again, etc.), so it's (relatively) obvious
what standalone mods should do?

-- 
Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.