[quake3-bugzilla] [Bug 4733] [patch] Q3UI: Clamp gametype to 4, there is no gametype 5

[bugzilla-daemon at icculus.org]

http://bugzilla.icculus.org/show_bug.cgi?id=4733

Zack "ZTurtleMan" Middleton <ZTurtleMan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |
   Attachment #2423|0                           |1
        is obsolete|                            |

--- Comment #4 from Zack "ZTurtleMan" Middleton <ZTurtleMan at gmail.com> 2010-09-01 12:13:15 EDT ---
Thilo, those gametypes are used in the missionpack (Quake III: Team Arena).
Missionpack will not work now. You could add a enum value
(GT_MAX_Q3UI_GAME_TYPE = 4), but it would probable be best to keep q3_ui only
stuff in q3_ui.

Maybe clamp to the length of the gametype_remap2 array? (That is why it must be
clamped, so it will always be correct.)

s_serveroptions.gametype = (int)Com_Clamp( 0, ARRAY_LEN(gametype_remap2) - 1,
trap_Cvar_VariableValue( "g_gametype" ) );

--- Comment #5 from Zack "ZTurtleMan" Middleton <ZTurtleMan at gmail.com> 2010-12-17 17:24:27 EST ---
Created an attachment (id=2537)
 --> (http://bugzilla.icculus.org/attachment.cgi?id=2537)
Revert r1796, fix clamping.

The missionpack is still broken. The attached patch fixes the missionpack and
closes this bug.

-- 
Configure bugmail: http://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.