[Bug 3771] New Visual Studio 2005 project file

[bugzilla-daemon at icculus.org]

http://bugzilla.icculus.org/show_bug.cgi?id=3771





------- Comment #18 from AnthonyJ at planetquake.com  2009-02-07 08:03 EDT -------
(In reply to comment #17)
> Created an attachment (id=1957)
 --> (http://bugzilla.icculus.org/attachment.cgi?id=1957&action=view) [details]
> unified diff between svn 1302 and the new hotness
> 
> Unified diff, hopefully this is correct.  If someone with VS2005 or VS2008 and
> either platform sdk or windows sdk can give this a try, cool beans!
> 

I haven't tried your patch, but it looks like it fixes at least two issues. IMO
what you've got there is much better than what is currently in SVN. 

However, reading the diff I still see references to libcurl.lib. Since this
file is not distributed as part of ioq3, I expect you to get an error trying to
link unless you have obtained libcurl.lib elsewhere. Note I'm actually using
VS2k3, so maybe in 2k5/2k8 its clever enough to realise that it doesn't matter
if a lib cannot be found if it is not actually required.

See lines similar to:
-                               AdditionalDependencies="user32.lib advapi32.lib
winmm.lib wsock32.lib openal32.lib SDLmain.lib SDL.lib OpenGL32.lib
libcurl.lib"
+                               AdditionalDependencies="user32.lib advapi32.lib
winmm.lib ws2_32.lib openal32.lib SDLmain.lib SDL.lib OpenGL32.lib libcurl.lib"

As you're defining USE_CURL_DLOPEN you do not need to link with libcurl.lib, so
this should be removed from these lines.

Personally I prefer my patch to the USE_LOCAL_HEADERS constant rather than
simply adding the \code\libcurl\... etc directories onto the include paths
since I feel this is more correct. Unless ioq3 is intended to only use the
local SDL / curl headers, I think this constant should be respected. Instead,
you're making sure a "local" directory is in the search path, which means it
will always use the local headers in preference to system, regardless of that
constant. Compare how the jpeg includes are redirected to the local path with
that constant set. However I do not particularly care - all I'm interested in
is the SVN head compiles. 


-- 
Configure bugmail: http://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.