[Bug 3605] New: fs_fakeChkSum? eh?

[bugzilla-daemon at icculus.org]

http://bugzilla.icculus.org/show_bug.cgi?id=3605

           Summary: fs_fakeChkSum? eh?
           Product: Quake 3
           Version: SVN HEAD
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P3
         Component: Misc
        AssignedTo: zakk at icculus.org
        ReportedBy: devhc97 at gmail.com
         QAContact: quake3-bugzilla at icculus.org


fs_fakeChkSum caught my eye.

When building a list of referenced paks on the client, if it's non-0, then it
is added as a pak checksum. It's a static global int (and therefore initialized
to 0). When we're accessing a non-(cfg|menu|...) file, it's set to random().
But random() returns a float between 0.0 and 1.0, and in all cases but 1.0 it
is truncated to 0. rand() would be the intended value. But with that fixed,
there's no reset (to 0) in either FS_Restart, or FS_ClearPakReferences, so
after visiting a non-pure server, we will never be pure again. But even with
that fixed, most importantly, on non-pure servers, the value's existance
doesn't matter, and on pure servers, no such files are referenced anyway.

I think it's uselessness and insignificance is what made it not noticable.
Remove (if yes, should I make a patch)?


-- 
Configure bugmail: http://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.