[Bug 3330] Memory write passed the end of allocated array

[bugzilla-daemon at icculus.org]

http://bugzilla.icculus.org/show_bug.cgi?id=3330


info at dbwatersports.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|info at dbwatersports.com      |zakk at icculus.org




------- Comment #5 from info at dbwatersports.com  2007-08-28 14:49 EDT -------
In StartServer_Cache, the array was being filled with all maps that were
loaded. This would cause memory to be overwritten if there were more than 64
maps loaded. I removed the code for storing at that point, because it was
superfluous. StartServer_Update was called shortyly after and it resets all of
the data.

The maximum arenas is set to 1024, so I changed the startserver_t structure to
have an integer index into the master arena list instead of keeping the map
name and the gamebits in the startserver_t structure. The map names are now
called as they are needed for display on the screen. The maximum is now set to
MAX_ARENAS (instead of 64) to match the maximum that will ever be there. This
will allow all maps to be displayed that match the criteria. (Well, all up to
1024 :-)

I've attached a new diff file with the proposed fix.


-- 
Configure bugmail: http://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.