[Bug 3324] New: Removing servers from favorites list in q3_ui/ui_servers2.c

[bugzilla-daemon at icculus.org]

http://bugzilla.icculus.org/show_bug.cgi?id=3324

           Summary: Removing servers from favorites list in
                    q3_ui/ui_servers2.c
           Product: Quake 3
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Misc
        AssignedTo: zakk at icculus.org
        ReportedBy: info at dbwatersports.com
         QAContact: quake3-bugzilla at icculus.org


In q3_ui/ui_servers2.c, in the function ArenaServers_Remove, there is an
incorrect value being used when shifting the servers up the list. The current
code uses sizeof(MAX_ADDRESSLENGTH) and should use MAX_ADDRESSLENGTH. This
happens around line number 580 and also around line 596. Both lines are memcpy
calls.

I have attached a .diff file, with several other changes in the surrounding
code. The code was a little messy, so I cleaned it up. I also added a memset to
zero for the last element in the list after the list has been shifted up. This
is not strictly needed, but ensures that the data will not accidentally show up
again (which it does with the current bug) if there are other bugs.

Obviously, the only required change is removal of the sizeof() that wraps
MAX_ADDRESSLENGTH, so do as you wish... Thanks...


-- 
Configure bugmail: http://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.