[physfs] Windows bug report + possible fix

Dennis Schridde devurandom at gmx.net
Tue Dec 11 13:47:32 EST 2007


Am Freitag, 9. November 2007 18:16:34 schrieb bugs buggy:
> I looked deeper into the physfs 1.1.1 code, and I noticed this line
> (1212) in windows.c
>     if (pGetFileAttributesW(wpath) == FILE_ATTRIBUTE_DIRECTORY)
>
> The issue is that pGetFileAttributesW(wpath)  was returning 0x2010  which
> is : FILE_ATTRIBUTE_NOT_CONTENT_INDEXED |  FILE_ATTRIBUTE_DIRECTORY
>
> So obviously it fails on the above piece of code.
> I changed the line to read :
> if (pGetFileAttributesW(wpath) & FILE_ATTRIBUTE_DIRECTORY)
>
> and it works as it should now.
Hi everyone!
It got a bit quiet lately. ;)

Ryan, do you have any opinion on this? A reason to not commit it, maybe?

--Dennis



More information about the physfs mailing list