[openbox] [PATCH] Window "Remember" keybind action

[Daniel Ramsay]

On Sun, Jan 31, 2010 at 11:07:00AM +0000, Daniel Ramsay wrote:
> 
> 
> On Sat, Jan 30, 2010 at 06:12:14PM +0000, Paul wrote:
> > On Fri, Jan 29, 2010 at 11:07:28PM +0000, Daniel Ramsay wrote:
> >> If you haven't tried this combination already, would you be able to try
> >> Control+F5 and Control+F6 - the windows key modifier mapping can be fiddly
> >> on some desktops.
> >
> > Just tried; same result. It sends the keycode to the window.
> >
> >> Unfortunately the patch that I submitted had the debug print statements
> >> taken out.  Are you happy to insert debug print statements into remember.c?
> >> I'd be curious to know if the action is being called.  I can send you
> >> another version of the patch if you'd prefer.
> >
> > You'd have to send another patch, I'm afraid :)
> >
> No problem.  I've been thinking that the action should provide proper visual
> feedback when it runs (especially when there's no other visible evidence of
> it having done anything).  One of my friends is a real usability fiend, and
> would give me a very severe kick for not having done so already :)
> 

OK - Here's a new version of the remember patch which displays one of
OpenBox's informational popups when a hotkey is assigned to a window.

The patch should be applied to a fresh unpack of 3.4.10 - it is much
easier than applying to a previously patched source directory.

Many thanks,

Daniel.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openbox_remember_w_notify_3.4.10.patch
Type: text/x-diff
Size: 6271 bytes
Desc: not available
URL: <http://icculus.org/pipermail/openbox/attachments/20100131/017ee64d/attachment.bin>