[Gtkradiant] PatchCreation bugfix: remaining brush will be removed

["Eduard Aumüller"]

Whats the indentation behind keeping the brush that was used to create patch?
It actually forces the user to remove it manually or to reselect it when creating another patch.
Former radiants didn t keep it either.

cu

-------- Original-Nachricht --------
Datum: Thu, 22 Mar 2007 14:40:55 -0000
Von: "Joseph, William" <WJoseph at europe.ea.com>
An: "GtkRadiant developer discussion" <gtkradiant at zerowing.idsoftware.com>
Betreff: RE: [Gtkradiant] PatchCreation bugfix: remaining brush will be removed

> Hi Eduard,
> 
> I am the one who implemented this feature originally. The behaviour you
> describe is as I originally intended.
> 
> I am telling you this because you appear to be mistakenly assuming that
> this behaviour is a bug. Assumptions like this are dangerous - when you make
> what seems like a simple bug-fix that changes this behaviour, you risk
> introducing other bugs and inconsistent behaviour. In addition, any change to
> an existing behaviour will have an impact on other users, who may prefer the
> existing behaviour.
> 
> Please be EXTREMELY careful when making any change to the behaviour of the
> editor, and consider ALL the impacts of your change! This is something I
> have learned through years of experience - ignore it at your peril.
> 
> -SPoG
> 
> 
> -----Original Message-----
> From: gtkradiant-bounces at zerowing.idsoftware.com
> [mailto:gtkradiant-bounces at zerowing.idsoftware.com] On Behalf Of "Eduard Aumüller"
> Sent: 18 March 2007 23:39
> To: gtkradiant at zerowing.idsoftware.com
> Subject: [Gtkradiant] PatchCreation bugfix: remaining brush will be
> removed
> 
> Hi, 
> you might have notices that when you create a patch from scratch, the
> previously selected brush will remain, unselected
> 
> 
> With the fix the unneeded brush will be gone.
> 
> Here is a little fix.
> 
> 1. get the selection bounds
> 2. clear the selection
> 3. create the patch with the previously gained AABB
> 
> code in patchmanip.cpp line 915
> 
> new code:
>  915                 //get the bounds of the current selection
>  916                 AABB patch_creator_aabb = PatchCreator_getBounds();
>  917
>  918                 //delete the current selection
>  919                 Select_Delete();
>  920
>  921                 //create the new patch
>  922                 Scene_PatchConstructPrefab(GlobalSceneGraph(),
> patch_creator_aabb,
>  923                        
> TextureBrowser_GetSelectedShader(GlobalTextureBrowser()), ePlane, GlobalXYWnd_getCurrentViewType(), w, h);
> 
> 
> please adjust this in the SVN repository
> 
> cya
> 
> -- 
> Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! 
> Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer
> 
> _______________________________________________
> Gtkradiant mailing list
> Gtkradiant at zerowing.idsoftware.com
> http://zerowing.idsoftware.com/cgi-bin/mailman/listinfo/gtkradiant
> 
> _______________________________________________
> Gtkradiant mailing list
> Gtkradiant at zerowing.idsoftware.com
> http://zerowing.idsoftware.com/cgi-bin/mailman/listinfo/gtkradiant

-- 
"Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ...
Jetzt GMX TopMail testen: www.gmx.net/de/go/mailfooter/topmail-out