[Gtkradiant] r106 - in GtkRadiant/trunk: contrib/cameracontrib/hydratoolz contrib/prtview plugins/textool radiant

[Joseph, William]

Hi,

Just a comment on style in the change to eclass_doom3.cpp:

(unsigned int)tokeniser.getLine()

In general never use C-style casts in GtkRadiant. Use either a C++ cast
or a function-style cast.

c++ cast:
static_cast<unsigned int>(tokeniser.getLine())

Function-style cast (same as static_cast but with simpler syntax):
Unsigned(tokeniser.getLine())

Note: The 'Unsigned' type is a typedef of 'unsigned int' intended for
this purpose.

Here's an article on why not to use C-style casts:
https://www.securecoding.cert.org/confluence/display/cplusplus/CAS00-A.+
Do+not+use+C-style+casts

Thanks for the contribution =).

-SPoG


-----Original Message-----
From: gtkradiant-bounces at zerowing.idsoftware.com
[mailto:gtkradiant-bounces at zerowing.idsoftware.com] On Behalf Of
svn-noreply at zerowing.idsoftware.com
Sent: 13 September 2006 23:26
To: gtkradiant at zerowing.idsoftware.com
Subject: [Gtkradiant] r106 - in GtkRadiant/trunk:
contrib/cameracontrib/hydratoolz contrib/prtview plugins/textool radiant

Author: lordhavoc
Date: Wed Sep 13 17:25:37 2006
New Revision: 106

Modified:
   GtkRadiant/trunk/contrib/camera/dialogs_common.cpp
   GtkRadiant/trunk/contrib/hydratoolz/plugin.cpp
   GtkRadiant/trunk/contrib/prtview/AboutDialog.cpp
   GtkRadiant/trunk/contrib/prtview/LoadPortalFileDialog.cpp
   GtkRadiant/trunk/plugins/textool/TexTool.cpp
   GtkRadiant/trunk/radiant/eclass_doom3.cpp
Log:
64bit compile fixes


Modified: GtkRadiant/trunk/contrib/camera/dialogs_common.cpp
Url:
http://zerowing.idsoftware.com/viewcvs/radiant/GtkRadiant/trunk/contrib/
camera/dialogs_common.cpp?view=diff&rev=106&p1=GtkRadiant/trunk/contrib/
camera/dialogs_common.cpp&r1=105&p2=GtkRadiant/trunk/contrib/camera/dial
ogs_common.cpp&r2=106
========================================================================
======

Modified: GtkRadiant/trunk/contrib/hydratoolz/plugin.cpp
Url:
http://zerowing.idsoftware.com/viewcvs/radiant/GtkRadiant/trunk/contrib/
hydratoolz/plugin.cpp?view=diff&rev=106&p1=GtkRadiant/trunk/contrib/hydr
atoolz/plugin.cpp&r1=105&p2=GtkRadiant/trunk/contrib/hydratoolz/plugin.c
pp&r2=106
========================================================================
======

Modified: GtkRadiant/trunk/contrib/prtview/AboutDialog.cpp
Url:
http://zerowing.idsoftware.com/viewcvs/radiant/GtkRadiant/trunk/contrib/
prtview/AboutDialog.cpp?view=diff&rev=106&p1=GtkRadiant/trunk/contrib/pr
tview/AboutDialog.cpp&r1=105&p2=GtkRadiant/trunk/contrib/prtview/AboutDi
alog.cpp&r2=106
========================================================================
======

Modified: GtkRadiant/trunk/contrib/prtview/LoadPortalFileDialog.cpp
Url:
http://zerowing.idsoftware.com/viewcvs/radiant/GtkRadiant/trunk/contrib/
prtview/LoadPortalFileDialog.cpp?view=diff&rev=106&p1=GtkRadiant/trunk/c
ontrib/prtview/LoadPortalFileDialog.cpp&r1=105&p2=GtkRadiant/trunk/contr
ib/prtview/LoadPortalFileDialog.cpp&r2=106
========================================================================
======

Modified: GtkRadiant/trunk/plugins/textool/TexTool.cpp
Url:
http://zerowing.idsoftware.com/viewcvs/radiant/GtkRadiant/trunk/plugins/
textool/TexTool.cpp?view=diff&rev=106&p1=GtkRadiant/trunk/plugins/textoo
l/TexTool.cpp&r1=105&p2=GtkRadiant/trunk/plugins/textool/TexTool.cpp&r2=
106
========================================================================
======

Modified: GtkRadiant/trunk/radiant/eclass_doom3.cpp
Url:
http://zerowing.idsoftware.com/viewcvs/radiant/GtkRadiant/trunk/radiant/
eclass_doom3.cpp?view=diff&rev=106&p1=GtkRadiant/trunk/radiant/eclass_do
om3.cpp&r1=105&p2=GtkRadiant/trunk/radiant/eclass_doom3.cpp&r2=106
========================================================================
======

_______________________________________________
Gtkradiant mailing list
Gtkradiant at zerowing.idsoftware.com
http://zerowing.idsoftware.com/cgi-bin/mailman/listinfo/gtkradiant