[Gtkradiant] CVS: reviewed todo stuff on bug 800 changes - preparing rollback
Timothee Besset
gtkradiant@zerowing.idsoftware.com
Sat, 10 May 2003 10:09:52 -0500
This is a mixed plain/HTML MIME encoded message.
--105257939229092
Content-Type: text/plain
User : timo
Root : zerowing:/cvs
Date : 2003/05/10 10:09:32
reviewed todo stuff on bug 800 changes - preparing rollback
--
GtkRadiant/docs/developer/CHANGES
1.377 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES?rev=1.377
diff :
that we distribute with the binaries. (see changelog)
05/05/2003
SPoG
- Changed archive file interface to use InputStream directly, removed InputStreamWrapper.
-
04/05/2003
SPoG
- Added an implementation of IArchive to do OS filesystem access.
- Changed vfspk3 to use above implementation for OS filesystem access.
--- 1,53 ----
This is the changelog for developers, != changelog for the end user
that we distribute with the binaries. (see changelog)
+ 09/05/2003
+ TTimo
+ - some easy fixes to get it to startup on Linux
+ - tagging the current source as bug800-spog, preparing rollback
+ - reviewed the code for all the broken stuff:
+
+ A list of broken things with bug800 patches:
+
+ http://www.qeradiant.com/wikifaq/index.php?Code%20Conventions
+ name classes correctly, name headers correctly, put them in the right places
+
+ class path_t
+
+
+ - ibytestream.h: remove this file completely. use IDataStream and extend idatastream.h header
+
+ - vfspk3/archive.cpp: typedef DIR* dir_t; <- bloat, using DIR* is fine
+
+ - WARNING: directory path does not end with separator
+ happens a lot during startup
+ GtkRadiant convention is to use trailing / on all directory paths
+
+ - class DirectoryListVisitor : public IArchive::IVisitor
+ don't declare classes inside classes. useless
+ specially in this case
+
+ - IVisitor to it's own header
+
+ - all those inline keywords are bloat. don't expect some inline keywords in the middle of STL bloat to make a perf difference
+
+ - class DirectoryListVisitor : public IArchive::IVisitor
+ declared and implemented at the same time in vfspk3/archive.cpp
+ use declaration, then implementation
+
+ - class DirectoryListVisitor : public IArchive::IVisitor
+ virtual statements in all those are useless. there are no children to override. only needed on the upper level class method
+
+ - DirectoryArchive::release: trash, use refcount class
+
05/05/2003
SPoG
- Changed archive file interface to use InputStream directly, removed InputStreamWrapper.
04/05/2003
+ TTimo
+ - remove vfswad from cons scripts
+
SPoG
- Added an implementation of IArchive to do OS filesystem access.
- Changed vfspk3 to use above implementation for OS filesystem access.
***************
*** 40,46 ****
- Updated win32 setup scripts for halflife media.
- Updated cons scripts for archivezip, archivewad and archivepak.
- Added printing of warnings when vfs functions are given invalid input paths.
-
28/04/2003
TTimo
--- 81,86 ----
5 files modified :
GtkRadiant/Construct
1.28 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/Construct?rev=1.28
1.27 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/Construct?rev=1.27
diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/Construct.diff?r1=1.27&r2=1.28
GtkRadiant/GtkRadiant.prj
1.10 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/GtkRadiant.prj?rev=1.10
1.9 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/GtkRadiant.prj?rev=1.9
diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/GtkRadiant.prj.diff?r1=1.9&r2=1.10
GtkRadiant/docs/developer/CHANGES
1.377 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES?rev=1.377
1.376 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES?rev=1.376
diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES.diff?r1=1.376&r2=1.377
GtkRadiant/plugins/vfspk3/archive.cpp
1.4 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/vfspk3/archive.cpp?rev=1.4
1.3 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/vfspk3/archive.cpp?rev=1.3
diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/vfspk3/archive.cpp.diff?r1=1.3&r2=1.4
GtkRadiant/plugins/vfspk3/vfs.cpp
1.33 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/vfspk3/vfs.cpp?rev=1.33
1.32 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/vfspk3/vfs.cpp?rev=1.32
diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/vfspk3/vfs.cpp.diff?r1=1.32&r2=1.33
--105257939229092
Content-Type: text/html
<html>
<head><title>CVS report</title></head>
<body bgcolor="#ffffff" text="#000000">
<table border=0 width="100%" cellspacing=0 cellpadding=0>
<tr>
<td align=left><b>Commit from <i>timo</i></b></td>
<td align=right valign=bottom>2003/05/10 10:09:32</td>
</tr>
</table>
<hr width="100%" size=2 noshade><br>
<code>
reviewed todo stuff on bug 800 changes - preparing rollback<br>
</code>
<hr width="100%" size=2 noshade><br>
<code>
<b>GtkRadiant/docs/developer/CHANGES</b>
<pre> that we distribute with the binaries. (see changelog)
05/05/2003
SPoG
- Changed archive file interface to use InputStream directly, removed InputStreamWrapper.
-
04/05/2003
SPoG
- Added an implementation of IArchive to do OS filesystem access.
- Changed vfspk3 to use above implementation for OS filesystem access.
--- 1,53 ----
This is the changelog for developers, != changelog for the end user
that we distribute with the binaries. (see changelog)
+ 09/05/2003
+ TTimo
+ - some easy fixes to get it to startup on Linux
+ - tagging the current source as bug800-spog, preparing rollback
+ - reviewed the code for all the broken stuff:
+
+ A list of broken things with bug800 patches:
+
+ http://www.qeradiant.com/wikifaq/index.php?Code%20Conventions
+ name classes correctly, name headers correctly, put them in the right places
+
+ class path_t
+
+
+ - ibytestream.h: remove this file completely. use IDataStream and extend idatastream.h header
+
+ - vfspk3/archive.cpp: typedef DIR* dir_t; <- bloat, using DIR* is fine
+
+ - WARNING: directory path does not end with separator
+ happens a lot during startup
+ GtkRadiant convention is to use trailing / on all directory paths
+
+ - class DirectoryListVisitor : public IArchive::IVisitor
+ don't declare classes inside classes. useless
+ specially in this case
+
+ - IVisitor to it's own header
+
+ - all those inline keywords are bloat. don't expect some inline keywords in the middle of STL bloat to make a perf difference
+
+ - class DirectoryListVisitor : public IArchive::IVisitor
+ declared and implemented at the same time in vfspk3/archive.cpp
+ use declaration, then implementation
+
+ - class DirectoryListVisitor : public IArchive::IVisitor
+ virtual statements in all those are useless. there are no children to override. only needed on the upper level class method
+
+ - DirectoryArchive::release: trash, use refcount class
+
05/05/2003
SPoG
- Changed archive file interface to use InputStream directly, removed InputStreamWrapper.
04/05/2003
+ TTimo
+ - remove vfswad from cons scripts
+
SPoG
- Added an implementation of IArchive to do OS filesystem access.
- Changed vfspk3 to use above implementation for OS filesystem access.
***************
*** 40,46 ****
- Updated win32 setup scripts for halflife media.
- Updated cons scripts for archivezip, archivewad and archivepak.
- Added printing of warnings when vfs functions are given invalid input paths.
-
28/04/2003
TTimo
--- 81,86 ----
</pre>
<table border=0 width="100%">
<tr>
<td colspan=5> </td>
</tr>
<tr bgcolor="#e0e0e0">
<td colspan=5 align=center><b>5 files modified</b></td>
</tr>
<tr>
<td><b>Module</b></td>
<td><b>File name</b></td>
<td colspan=3><b>Version</b></td>
</tr>
<tr>
<td><b>GtkRadiant</b></td>
<td><code>Construct</code></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/Construct?rev=1.27">1.27</a></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/Construct.diff?r1=text&tr1=1.27&r2=text&tr2=1.28&f=h">>>></a></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/Construct?rev=1.28">1.28</a></td>
</tr>
<tr>
<td><b>GtkRadiant</b></td>
<td><code>GtkRadiant.prj</code></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/GtkRadiant.prj?rev=1.9">1.9</a></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/GtkRadiant.prj.diff?r1=text&tr1=1.9&r2=text&tr2=1.10&f=h">>>></a></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/GtkRadiant.prj?rev=1.10">1.10</a></td>
</tr>
<tr>
<td><b>GtkRadiant</b></td>
<td><code>docs/developer/CHANGES</code></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES?rev=1.376">1.376</a></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES.diff?r1=text&tr1=1.376&r2=text&tr2=1.377&f=h">>>></a></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES?rev=1.377">1.377</a></td>
</tr>
<tr>
<td><b>GtkRadiant</b></td>
<td><code>plugins/vfspk3/archive.cpp</code></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/vfspk3/archive.cpp?rev=1.3">1.3</a></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/vfspk3/archive.cpp.diff?r1=text&tr1=1.3&r2=text&tr2=1.4&f=h">>>></a></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/vfspk3/archive.cpp?rev=1.4">1.4</a></td>
</tr>
<tr>
<td><b>GtkRadiant</b></td>
<td><code>plugins/vfspk3/vfs.cpp</code></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/vfspk3/vfs.cpp?rev=1.32">1.32</a></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/vfspk3/vfs.cpp.diff?r1=text&tr1=1.32&r2=text&tr2=1.33&f=h">>>></a></td>
<td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/vfspk3/vfs.cpp?rev=1.33">1.33</a></td>
</tr>
</table>
</body>
</html>
--105257939229092--