[Gtkradiant] [Bug 436] Copy and pasting entity, then modifying epairs of the new ent borks

gtkradiant@zerowing.idsoftware.com gtkradiant@zerowing.idsoftware.com
Wed, 18 Sep 2002 10:49:43 -0500


http://zerowing.idsoftware.com/bugzilla/show_bug.cgi?id=436

rr2do2@q3f.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|                            |All



------- Additional Comments From rr2do2@q3f.com  2002-09-18 10:49 -------
after this, bringing up the entity inspector became very slow. This is because 
select_reselect is really slow. But why?

select reselet gets a list of all selected brushes, then reselects every one of 
them through select_brush. Select brush looks if a brush is part of an entity, 
and if so, (re)selects every brush in the entity. So if you have a terrain 
entity selected with 5000 odd brushes, every brush will be reselected about 
5000 times. I haven't tested this properly yet, but modifying select_reselect 
to say

void Select_Reselect()
{

  Select_Brush(selected_brushes.next);
  
  Sys_UpdateWindows (W_ALL);
}

instead seems to work fine and take care of everything. (The fix gef did for 
this bug is the only function calling select_reselect though)