[Gtkradiant] [Bug 663] Gensurf crash

gtkradiant@zerowing.idsoftware.com gtkradiant@zerowing.idsoftware.com
Sun, 10 Nov 2002 05:46:21 -0600


ttimo@idsoftware.com changed:

           What    |Removed                     |Added
             Status|NEW                         |ASSIGNED

------- Additional Comments From ttimo@idsoftware.com  2002-11-10 05:46 -------
this crash highlights a VERY BAD change in the plugin API

that kind of functionality change is NOT something to do on a stable source tree

it should have been done properly by introducing a second API call that has the
new behaviour. All plugins that are using m_pfnCommitEntityHandleToMap got
broken because of that.

This has several bad consequences:
- added instability to the stable version
- broke any third party plugin using the API
- make stable maintenance time higher and delay further beta release (1.3)
because of the above

Changes to the stable source should ALWAYS follow the following guidelines:

- NEVER change the behaviour of the APIs. Introduce new calls if you need to do
- NEVER do that kind of changes without properly documenting them. Hiding them
in a bug patch that covers a whole bunch of issues is NOT a solution