[Gtkradiant] CVS: making toolbar api prettier
Timothee Besset
gtkradiant@zerowing.idsoftware.com
Tue, 17 Dec 2002 11:34:29 +0100
Please follow the general C++ standards and name your classes correctly!
http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/include/itoolbar.h.diff?r1=1.2.2.2&r2=1.2.2.3
We now have a pure virtual interface for the toolbar buttons, which is
what we should have had from the beginning. BUT the naming conventions are
still absolutely wrong.
class toolbar_button_t needs to renamed in IToolbarButton
and the implementation written as ToolbarButton
+ it is still missing IRefCount inheritance and RefCounting usage
TTimo
On Tue, 17 Dec 2002 04:33:12 -0600
William Joseph <spog@zerowing.idsoftware.com> wrote:
> User : spog
> Branch : merge-1_2_10-post
> Root : zerowing:/cvs
> Date : 2002/12/17 04:33:05
>
> making toolbar api prettier
>
> --
>
> 3 files modified :
>
> GtkRadiant/include/itoolbar.h
> 1.2.2.3 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/include/itoolbar.h?rev=1.2.2.3
> 1.2.2.2 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/include/itoolbar.h?rev=1.2.2.2
> diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/include/itoolbar.h.diff?r1=1.2.2.2&r2=1.2.2.3
>
> GtkRadiant/plugins/model/plugin.cpp
> 1.2.2.4 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/model/plugin.cpp?rev=1.2.2.4
> 1.2.2.3 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/model/plugin.cpp?rev=1.2.2.3
> diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/plugins/model/plugin.cpp.diff?r1=1.2.2.3&r2=1.2.2.4
>
> GtkRadiant/radiant/pluginmanager.cpp
> 1.78.2.4 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/pluginmanager.cpp?rev=1.78.2.4
> 1.78.2.3 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/pluginmanager.cpp?rev=1.78.2.3
> diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/pluginmanager.cpp.diff?r1=1.78.2.3&r2=1.78.2.4
>
>