[Gtkradiant] [Bug 203] New: Speedup and Fix of eclass.cpp setSpecialLoad()

gtkradiant@zerowing.idsoftware.com gtkradiant@zerowing.idsoftware.com
Sat, 29 Sep 2001 12:32:57 -0500


http://zerowing.idsoftware.com/bugzilla/show_bug.cgi?id=203

           Summary: Speedup and Fix of eclass.cpp setSpecialLoad()
           Product: GtkRadiant
           Version: 1.2-nightly
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: editor
        AssignedTo: ttimo@idsoftware.com
        ReportedBy: hydra@hydras-world.com


This diff patches eclass.cpp's setSpecialLoad() function

The old version repeatedly used "str += mychar" forcing the CString
class to allocate a new string, copy the old one to it, add
the character and then free the old string over and over and over
again.

The replacement fixes this and removes CString usage at the same time
(so that it can be moved to a module more easily).

This patch could also be used in 1.1.1. (As it's a replacement function, just 
cut and paste)

Diff Created using WinCVS on the 1.2 branch.



------- You are receiving this mail because: -------
Whoops!  I have no idea!