[Gtkradiant] [Bug 149] New: use xmlChar instead of CHAR or char for SAX/XML stuff...

[gtkradiant@zerowing.idsoftware.com]

http://zerowing.idsoftware.com/bugzilla/show_bug.cgi?id=149

           Summary: use xmlChar instead of CHAR or char for SAX/XML stuff...
           Product: GtkRadiant
           Version: 1.2-nightly
          Platform:
               URL:
        OS/Version: Linux
            Status: NEW
 Status Whiteboard:
          Keywords:
        Resolution:
          Severity: blocker
          Priority: P2
         Component: setup
        AssignedTo: eviltypeguy@qeradiant.com
        ReportedBy: eviltypeguy@qeradiant.com


The other night I was having compilation problems under linux with the "IMap"
branch of GtkRadiant, at first I thought it was an obvious oversight by MSVC
programmers, using "const CHAR *" instead of "const char". As such I suggested
to ttimo that he change those references and at the time it seemed like the
"right thing to do"(TM). However, during my re-edumacation [sic] after reading a
concise explanation of libxml and gnome-xml I discovered a discrepancy.

version .x and 1.x of libxml was known as gnome-xml, which inside of the tree.h
file defines 'CHAR' as 'unsigned char', however we use and require libxml2 which
does not follow this logic. libxml2 defines 'xmlChar' as 'unsigned char', so
while the data type hasn't changed internally, what we should be using for those
'const CHAR *' declarations has.

I'll attach a .patch to this bug to reverse my mistake which appears to still
keep everything in it's current semi-functional state and reverses my stupidity
regarding this issue...