Hello again,<br><br>I *think* I've managed to fix the things that you suggested. The only thing I can't get to work is saving the preferred size of the notes pane (the VBox doesn't seem to emit a configure event - I guess maybe I could change it so that when the program is quit the preference is updated, but it'd be nice to get it to work the "right" way). I apologize for messy code - once again, this is mostly a learning experience for me.<br>
<br>Charlotte<br><br><div class="gmail_quote">On Mon, May 5, 2008 at 3:38 PM, Charlotte Curtis <<a href="mailto:c.f.curtis@gmail.com">c.f.curtis@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Thanks John, I have to admit I didn't quite know what I was doing at times, and I was just excited that the whole thing more or less worked. I originally wanted to implement this feature as a plugin, but it seemed that the required changes to the document class as well as the UI changes would be a little too complex. I'll take a crack at fixing the things you pointed out, and I'm sure more will pop up along the way. Thanks again,<br>
<font color="#888888">
<br>Charlotte</font><div><div></div><div class="Wj3C7c"><br><br><div class="gmail_quote">On Mon, May 5, 2008 at 3:02 PM, John Spray <<a href="mailto:jcspray@icculus.org" target="_blank">jcspray@icculus.org</a>> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>On Mon, 2008-05-05 at 13:35 -0400, Charlotte Curtis wrote:<br>
> Hi all,<br>
><br>
> I've been using referencer for a while, but one thing I always wanted<br>
> to be able to do was to take notes about my articles. I had a bit of<br>
> free time and a desire to learn about gtkmm, so I tried to add some<br>
> basic note functionality. I've attached the patch to this email in<br>
> case anyone wants to check it out. The functionality that should<br>
> exist now is:<br>
<br>
</div>Good stuff. You're not the first person to wish for annotation, so I<br>
expect this to be popular.<br>
<br>
I've committed the patch with the following changes:<br>
* Fixed up the label strings to be translatable<br>
* Got rid of the accelerator for export to HTML, it clashed with<br>
"Save As". I don't think it's really frequently used enough to<br>
need an accelerator anyway.<br>
* Move the export action from the Tools menu to the Library menu:<br>
the Tools menu is provided primarily for plugins providing any<br>
truly obscure items: actions starting "export" should probably<br>
go together. Library menu is a bit cluttered now, but it's the<br>
lesser of two evils until I figure out a non-evil way.<br>
Diff at <a href="http://hg.icculus.org/jcspray/referencer/rev/922d9cf167b9" target="_blank">http://hg.icculus.org/jcspray/referencer/rev/922d9cf167b9</a><br>
<br>
I couldn't find any serious bugs in the patch, but that doesn't mean<br>
the ravenous hordes won't: I'd encourage anyone comfortable with running<br>
from hg to try out the latest.<br>
<br>
There are some other changes I'd like to see before releasing it:<br>
* The HTML output should include a meta tag specifying UTF-8<br>
encoding, assuming this is what comes out when one does a <<<br>
between std::ofstream and Glib::ustring. See for example<br>
www/index.html.<br>
* I don't like the invocation of docSelectionChanged in<br>
onSaveLibrary: I think adding a function that commits any<br>
outstanding notes changes would be preferable, even if this is<br>
the only place it's used.<br>
* Document titles should be ellipsized to the available space -<br>
really long titles otherwise cause the window to be resized. I<br>
tried using set_ellipsize on the label from<br>
notespane_->get_label_widget, but it didn't have the correct<br>
effect. Probably a Gtk::Frame problem. See the first item of<br>
the next list.<br>
<br>
And some things that would be nice:<br>
* A Gtk::Stock::CLOSE button in the top right corner of the notes<br>
area. Should be simple if you replace the Gtk::Frame(TextView)<br>
with Vbox(Hbox(Label,Button), TextView). That would also allow<br>
adding some space around the "Notes for" label which is a bit<br>
cramped as it is.<br>
* The size of the notes area should be saved as a preference -- I<br>
can imagine users having wildly different expectations of the<br>
"right" size.<br>
* If a document has an empty title it would be nice to use the key<br>
name instead or failing that put "unnamed" rather than having<br>
the abrupt "Notes for"<br>
<br>
<br>
Cheers,<br>
John<br>
<br>
<br>
---<br>
To unsubscribe, send a blank email to <a href="mailto:referencer-unsubscribe@icculus.org" target="_blank">referencer-unsubscribe@icculus.org</a><br>
Mailing list archives: <a href="http://icculus.org/cgi-bin/ezmlm/ezmlm-cgi?60" target="_blank">http://icculus.org/cgi-bin/ezmlm/ezmlm-cgi?60</a><br>
<br>
<br>
</blockquote></div><br>
</div></div></blockquote></div><br>