[referencer] [PATCH] Add tags through a cell in the tags view instead of a dialog

[John Spray]

On Thu, 2007-05-17 at 00:52 -0700, Eric Lesh wrote:
> > One thing that makes me uncomfortable is the way the treepath for the
> > new tag is found -- I'm not sure the assumption that it's going to be at
> > the end will always be valid, if there is any sorting going on.  Also,
> > adding 2 to skip the "All documents" and "Untagged documents" is a
> > dangerously magic number.
> 
> I thought the same thing and originally had a comment to that effect in
> there.  Of course, the sort should be done after the tag is actually
> edited and so the "Type a tag" should always end up at the bottom for
> consistency sake.  Having your new tag always appear between the T's
> would be a pain.
> 
> The  magic 2 is pretty shifty.  Will fix.

Any progress on this?  I've just implemented the sorting of tags in the
list, so onCreateTag is broken until it gets more intelligent about
picking out the new tag.

As for whether to put the "Type a tag" at the bottom of the list, I'm
not sure, but in any case it would be much preferable to have it cope
regardless.

John