[quake3] 'Remove Useless setuid code' ???

[Ian Kumlien]

On Sat, 2005-09-03 at 17:54 +0200, Ludwig Nussel wrote:
> Am Samstag, 3. September 2005 17:44 schrieb Ian Kumlien:
> > It seems like the setuid is infact useless and related to that root
> > usually owns devices like that... I also seem to remember that id
> > discuraged ppl from running it setuid.. (i'm tired though so it might be
> > context leakage).
> 
> It was not only useless but also dangerous. Q3 clearly is not
> designed to run setuid root plus the way it tried to drop the
> privileges was broken.

Heh, ok, good, someone who ahs checked the code in all contexts, i just
looked at the diff.. 

> > Anyways, if we merged that, then why not <see attachment/>
> 
> I'd even remove the bit that tries to load libgl from the current
> directory. One can just as well set LD_LIBRARY_PATH="." to achieve
> that.

Hummm thats a fall back if ld.so.conf can't find it... 
But something like this?

-- 
Ian Kumlien <pomac () vapor ! com> -- http://pomac.netswarm.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: q3-setuid-cleanup-2.diff
Type: text/x-patch
Size: 1386 bytes
Desc: 
URL: <http://icculus.org/pipermail/quake3/attachments/20050903/a13f3b5e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://icculus.org/pipermail/quake3/attachments/20050903/a13f3b5e/attachment.pgp>