'Remove Useless setuid code' ???

vincent at cojot.name vincent at cojot.name
Sat Sep 3 09:41:46 EDT 2005


Just saw a bunch of 'Remove Useless setuid code' in svn.

Could we know why these were removed and also more generally what kind of 
approval/testing does a new patch get before it's accepted in svn?

Can we at least see and discuss these patches first on the mailing list?

Maybe this kind of 'getuid() == saved_euid)' isn't needed on Linux but it 
might be useful on other platforms. Can we please take care not to change 
too much the actual code that worked? If the goal of the project isn't to 
remain stable and extended the cross-platformability of the engine, Please 
say so, that's fine with me: I'll just fork a new project where I'll 
invest time in the non-Linux ports..

When I worked on i-o-q2, many of the patches that got into CVS were tested 
on Linux/x86 only and immediately found their way into CVS where I had to 
fix them afterwards while I always backported my Solaris fixes to the 
generic UNIX tree. In the recent years, I ported the TGE engine to 
Solaris/Sparc and some things were never fixed because it was/is/will 
mostly x86-only 'oriented'.

Thanks for reading,

Please don't flame. :)

Vincent



More information about the quake3 mailing list