From noreply at github.com  Thu Jul  6 05:03:50 2023
From: noreply at github.com (=?UTF-8?B?VGhlIFR1cnRsZSBNYW4g4pmj?=)
Date: Thu, 06 Jul 2023 02:03:50 -0700
Subject: [quake3-commits] [ioquake/ioq3] efd55c: nsis: Remove Speex library
Message-ID: <ioquake/ioq3/push/refs/heads/main/e452b7-2bca42@github.com>

  Branch: refs/heads/main
  Home:   https://github.com/ioquake/ioq3
  Commit: efd55cab9de35d33050ef246c7ac0d3cc47739f6
      https://github.com/ioquake/ioq3/commit/efd55cab9de35d33050ef246c7ac0d3cc47739f6
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M misc/nsis/Makefile
    M misc/nsis/ioquake3.nsi.in

  Log Message:
  -----------
  nsis: Remove Speex library

The game doesn't support it anymore.


  Commit: 9738176849bcf09566e2ad602d07e40a9a8d18ef
      https://github.com/ioquake/ioq3/commit/9738176849bcf09566e2ad602d07e40a9a8d18ef
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M misc/nsis/ioquake3.nsi.in

  Log Message:
  -----------
  nsis: Require installing SDL

It's required to run and unlikely to be installed system wide.


  Commit: 5362af3858d83fb1c6ec03ad731be3fe28bbfb21
      https://github.com/ioquake/ioq3/commit/5362af3858d83fb1c6ec03ad731be3fe28bbfb21
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M misc/nsis/ioquake3.nsi.in

  Log Message:
  -----------
  nsis: Display ioquake3 version

Display version in the installer and add/remove software.


  Commit: 221465f3b44639536631cbb7ba20e12fa5e7e179
      https://github.com/ioquake/ioq3/commit/221465f3b44639536631cbb7ba20e12fa5e7e179
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M misc/nsis/ioquake3.nsi.in

  Log Message:
  -----------
  nsis: Add better descriptions for OpenAL and libcurl


  Commit: a119e67fb8c20d1eacebdaa54744660478898a03
      https://github.com/ioquake/ioq3/commit/a119e67fb8c20d1eacebdaa54744660478898a03
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M misc/nsis/ioquake3.nsi.in

  Log Message:
  -----------
  nsis: Fix CustomUrlArguments for protocol handler


  Commit: 2bca424fcea98b30f0a6575327ee645d010f38b2
      https://github.com/ioquake/ioq3/commit/2bca424fcea98b30f0a6575327ee645d010f38b2
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M misc/nsis/ioquake3.nsi.in

  Log Message:
  -----------
  nsis: Only uninstall protocol handler for this installation


Compare: https://github.com/ioquake/ioq3/compare/e452b7ac04b0...2bca424fcea9

From noreply at github.com  Thu Jul  6 05:10:19 2023
From: noreply at github.com (=?UTF-8?B?VGhlIFR1cnRsZSBNYW4g4pmj?=)
Date: Thu, 06 Jul 2023 02:10:19 -0700
Subject: [quake3-commits] [ioquake/ioq3] 10a45c: Don't list mod directories
 at Windows drive root
Message-ID: <ioquake/ioq3/push/refs/heads/main/2bca42-10a45c@github.com>

  Branch: refs/heads/main
  Home:   https://github.com/ioquake/ioq3
  Commit: 10a45cbdc131a35530d89bd3cfc2a7eed74b54cc
      https://github.com/ioquake/ioq3/commit/10a45cbdc131a35530d89bd3cfc2a7eed74b54cc
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M code/sys/sys_unix.c
    M code/sys/sys_win32.c

  Log Message:
  -----------
  Don't list mod directories at Windows drive root

The mod list on Windows would search the root of the drive if
fs_basepath, fs_homepath, fs_steampath, or fs_gogpath are blank ("")
(which is usually the case).

The issue is in the low-level Sys_ListFiles() but it only affects the
mod menu, on Windows. It cannot be abused by console commands to
list system files outside of the virtual filesystem.

---

If a directory at the root of the drive of the working directory
contained a pk3 file, the directory was listed in the mods menu. The
virtual filesystem doesn't add blank directory names to the search path
so it cannot load mods from the drive root. (Unless of course you set a
fs_*path cvar to "C:\".)

Sys_ListFiles() with blank directory caused Windows to use "\*" for the
search path and "\" prefix means root of drive. Unix opendir("") failed
so nothing was listed for blank directory.

Sys_ListFilteredFiles() with blank directory _and_ specifying subdirs
could access any directory (on Windows and Unix-like) but no code uses
this or makes it accessible.

These functions are only used for initializing the virtual filesystem
and listing mods. They are not accessible by anything else such as a
console command. Only the mods menu, on Windows, is affected.