[quake3-commits] [ioquake/ioq3] acce0e: Fix building msvc12 project

Zack Middleton zack at cloemail.com
Tue Jan 30 08:59:56 EST 2018


  Branch: refs/heads/master
  Home:   https://github.com/ioquake/ioq3
  Commit: acce0e5452752f5346d3f6eacf10658bf4b21f0d
      https://github.com/ioquake/ioq3/commit/acce0e5452752f5346d3f6eacf10658bf4b21f0d
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2018-01-30 (Tue, 30 Jan 2018)

  Changed paths:
    M misc/msvc12/cgame.vcxproj
    M misc/msvc12/game.vcxproj
    M misc/msvc12/opengl1.vcxproj
    M misc/msvc12/opengl2.vcxproj
    M misc/msvc12/q3_ui.vcxproj
    M misc/msvc12/quake3.vcxproj
    M misc/msvc12/quake3.vcxproj.filters
    M misc/msvc12/ui.vcxproj

  Log Message:
  -----------
  Fix building msvc12 project

* Don't try to embed manifest (it causes build to fail because it's
  specified in win_resource.rc).
* Fix curl include path.
* Compile sys_autoupdater.c.
* Make quake3 debug link to msvcrtd.lib instead of msvcrt.lib to fix
  unresolved external symbol __imp___CrtDbgReportW.
* Fix q3_ui dll output directory.
* Fix opus path filter.
* Use UseOfMfc false and CharacterSet NotSet.
* Fix header paths and remove non-existent files.


  Commit: df8f657f09b43c8e097c0f61e170c4b6599ffd74
      https://github.com/ioquake/ioq3/commit/df8f657f09b43c8e097c0f61e170c4b6599ffd74
  Author: Zack Middleton <zack at cloemail.com>
  Date:   2018-01-30 (Tue, 30 Jan 2018)

  Changed paths:
    M code/sys/sys_win32.c

  Log Message:
  -----------
  Fix exploit to bypass filename restrictions on Windows

Windows API ignores all trailing spaces and periods which can get around
Quake 3 file system restrictions. QVM opening 'uix86.dll.' actually
opens 'uix86.dll' which allows QVM to write native code.

This is done in the low-level Sys_FOpen() instead of the function
directly used by VMs ( FS_FOpenFileByMode() ) in case there are engine
commands now or in the future that can read or write arbitrary files.

Reported by Noah Metzger (Chomenor).


Compare: https://github.com/ioquake/ioq3/compare/738465d677bd...df8f657f09b4


More information about the quake3-commits mailing list