[quake3-commits] [ioquake/ioq3] 9d7422: Fix potential out of bounds access caused by CM_Gr...

[Zack Middleton]

  Branch: refs/heads/master
  Home:   https://github.com/ioquake/ioq3
  Commit: 9d74227559d46b85d0c43d395cd280d3de7ae8f4
      https://github.com/ioquake/ioq3/commit/9d74227559d46b85d0c43d395cd280d3de7ae8f4
  Author: Zack Middleton <zturtleman at gmail.com>
  Date:   2014-05-25 (Sun, 25 May 2014)

  Changed paths:
    M code/qcommon/cm_patch.c

  Log Message:
  -----------
  Fix potential out of bounds access caused by CM_GridPlane

Coverity doesn't care if there is a warning, out of bounds access is bad.


  Commit: e21ff01946c425b345abd8c0910864eaa61a6848
      https://github.com/ioquake/ioq3/commit/e21ff01946c425b345abd8c0910864eaa61a6848
  Author: Zack Middleton <zturtleman at gmail.com>
  Date:   2014-05-25 (Sun, 25 May 2014)

  Changed paths:
    M code/renderergl2/tr_model.c

  Log Message:
  -----------
  Don't use memset with non-zero value to fill ints

Coverity reported using value -2 as a bad memset. Really doesn't make sense when filling ints and not bytes too.


  Commit: 078d004dc272759154caf83ca9549c3a4c0cb5ee
      https://github.com/ioquake/ioq3/commit/078d004dc272759154caf83ca9549c3a4c0cb5ee
  Author: Zack Middleton <zturtleman at gmail.com>
  Date:   2014-05-25 (Sun, 25 May 2014)

  Changed paths:
    M code/botlib/l_script.c

  Log Message:
  -----------
  Fix potential buffer overflow in PS_ReadPrimitive

Found by Coverity.


  Commit: eea9fbdb61d95cf48cbcdaa3b5f38daadc0ce1c6
      https://github.com/ioquake/ioq3/commit/eea9fbdb61d95cf48cbcdaa3b5f38daadc0ce1c6
  Author: Zack Middleton <zturtleman at gmail.com>
  Date:   2014-05-25 (Sun, 25 May 2014)

  Changed paths:
    M code/botlib/l_precomp.c
    M code/botlib/l_script.c

  Log Message:
  -----------
  Fix unchecked buffer size issues in l_script.c and l_precomp.c

Found by Coverity.


  Commit: 7a4ef47476e52e10828453b033c8546a55ef8081
      https://github.com/ioquake/ioq3/commit/7a4ef47476e52e10828453b033c8546a55ef8081
  Author: Zack Middleton <zturtleman at gmail.com>
  Date:   2014-05-25 (Sun, 25 May 2014)

  Changed paths:
    M code/server/sv_ccmds.c

  Log Message:
  -----------
  Fix max bans range check in SV_AddBanToList

Adding too many bans would write out of bounds. Found by Coverity.


  Commit: 9c99cf29db06807fd96acfdbc6c59bbbbcd4a814
      https://github.com/ioquake/ioq3/commit/9c99cf29db06807fd96acfdbc6c59bbbbcd4a814
  Author: Zack Middleton <zturtleman at gmail.com>
  Date:   2014-05-25 (Sun, 25 May 2014)

  Changed paths:
    M code/renderergl2/tr_shader.c

  Log Message:
  -----------
  Have OpenGL2 "map $lightmap" check for NULL tr.lightmaps too

Zero length lightmap lump will have NULL tr.lightmaps.

OpenGL1 already has this check, because r_vertexLight 1
would crash Team Arena. OpenGL2 does not disable loading lightmaps
when r_vertexLight is 1 though, so it does not have that issue.


  Commit: eeeaf3f1252d95a6037f33d30fdf2e945e340f79
      https://github.com/ioquake/ioq3/commit/eeeaf3f1252d95a6037f33d30fdf2e945e340f79
  Author: Zack Middleton <zturtleman at gmail.com>
  Date:   2014-05-25 (Sun, 25 May 2014)

  Changed paths:
    M code/renderergl1/tr_shader.c
    M code/renderergl2/tr_shader.c

  Log Message:
  -----------
  Fix potential buffer overflow caused by long tcMod args

Found by Coverity.


Compare: https://github.com/ioquake/ioq3/compare/494789664e3c...eeeaf3f1252d