From bugzilla-daemon at icculus.org  Wed Jan 11 08:11:47 2017
From: bugzilla-daemon at icculus.org (bugzilla-daemon at icculus.org)
Date: Wed, 11 Jan 2017 13:11:47 +0000
Subject: [quake3-bugzilla] [Bug 6030] Team Arena Single Player broken,
	always spectator
In-Reply-To: <bug-6030-2348@http.bugzilla.icculus.org/>
References: <bug-6030-2348@http.bugzilla.icculus.org/>
Message-ID: <bug-6030-2348-H4tqswnat4@http.bugzilla.icculus.org/>

https://bugzilla.icculus.org/show_bug.cgi?id=6030

James Canete <use.less01 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3387|0                           |1
        is obsolete|                            |

--- Comment #9 from James Canete <use.less01 at gmail.com> ---
Created attachment 3575
  --> https://bugzilla.icculus.org/attachment.cgi?id=3575&action=edit
allow early team command v2

Well, no-one seems to have thought about this patch for a while, so I decided
to think about it.

It seems safe to me.  The only behavior changed is when a local client requests
a team change when it's technically not connected.  The UDP spoofing protection
in Netchan_Process() in net_chan.c should prevent any spoofed messages from
triggering this code path, and if that's not reliable, all bets are already
off.

The only change I would make is to re-enable the initial connected check and
add an exception for a local client, to avoid always calling the trap_Argv()
syscall.

Changes attached.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://icculus.org/pipermail/quake3-bugzilla/attachments/20170111/a072dcd6/attachment.html>